Introduce CArray.of_string and expand the string view documentation
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 3, 2018 16:49
Having a function to make an ocaml string into a managed CArray to pass to the c bindings could make it clearer that string views are not always the best ways to deal with strings when interfacing with C Signed-off-by: Marcello Seri <[email protected]>
Signed-off-by: Marcello Seri <[email protected]>
Signed-off-by: Marcello Seri <[email protected]>
|
The android build failure seems to be independent of this PR |
|
Thank you for the contribution, @mseri! I think this is a useful addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have already expanded a bit the comments on the FAQ. Feel free to close this PR if you think it's superfluous, but I thought that passing strings in C structure fields and similar type of bindings are probably not that uncommon, and it may be useful to be hinted that
stringviews are not the right thing both by the documentation and by the presence of a function likeCArray.of_string.