Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): Multi-DHTs support and stmt reuse bug #31

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Conversation

cnlangzi
Copy link
Member

@cnlangzi cnlangzi commented Apr 9, 2024

Changes

  • added Multi-DHTs support

Fixes

  • fixed the stmt that is in using should not be closed by clean worker.

@cnlangzi cnlangzi changed the title fix(db): Multi-DHTs support and release stmt bug fix(db): Multi-DHTs support and stmt close bug Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 98.73418% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.77%. Comparing base (2acb436) to head (dd1f9ee).

❗ Current head dd1f9ee differs from pull request most recent head f034a00. Consider uploading reports for the commit f034a00 to get more accurate results

Files Patch % Lines
tx.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   73.67%   74.77%   +1.10%     
==========================================
  Files          40       40              
  Lines        1637     1665      +28     
==========================================
+ Hits         1206     1245      +39     
+ Misses        317      309       -8     
+ Partials      114      111       -3     
Flag Coverage Δ
Unit-Tests 74.77% <98.73%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

context_stmt.go Show resolved Hide resolved
row.go Show resolved Hide resolved
rows.go Show resolved Hide resolved
Copy link

deepsource-io bot commented Apr 9, 2024

Here's the code health analysis summary for commits 2acb436..f034a00. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cnlangzi cnlangzi changed the title fix(db): Multi-DHTs support and stmt close bug fix(db): Multi-DHTs support and stmt reuse bug Apr 9, 2024
@cnlangzi cnlangzi merged commit 65ab358 into main Apr 9, 2024
5 checks passed
@cnlangzi cnlangzi deleted the fix/multi_dht branch April 9, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant