-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced object literals support #39
Conversation
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
/cc @kwolfy looks it is require accept CLA, can you accept? |
/cc @okuryu can you review PR? |
I accepted |
/cc @redonkulus |
This comment was marked as outdated.
This comment was marked as outdated.
/cc @okuryu |
This comment was marked as outdated.
This comment was marked as outdated.
OK, let's review.. It seems not to have tests for |
@okuryu yep, but we run test on node@4 and it is impossible to test |
right |
oops! I see 😅 |
/cc @okuryu can we merge this and release new version? We have some problems in |
Sorry for delay! I just merged and published |
Unfortunately I could not cover the case with async enhanced object literals, cause in travis CI you have nodejs=4 tests
Fix #33