Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply checkstyle to all modules #154

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

liran-funaro
Copy link
Contributor

@liran-funaro liran-funaro commented Mar 30, 2021

Fixes issue #153

  • Apply checkstyle to all modules
  • Add "WhitespaceAround" to checkstyle rules

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

- Add "WhitespaceAround" to checkstyle rules
@sanastas
Copy link
Contributor

Looks like there were check-style errors :(

@liran-funaro
Copy link
Contributor Author

Looks like there were check-style errors :(

Yeah. I didn't fix the issues yet. Now there are no errors.

Copy link
Contributor

@sanastas sanastas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good contribution, minor comment below.

core/src/main/java/com/yahoo/oak/Chunk.java Outdated Show resolved Hide resolved
@liran-funaro liran-funaro merged commit cb55aae into yahoo:master Apr 20, 2021
@liran-funaro liran-funaro deleted the checkstyle-tests branch April 20, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants