Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google oAuth integrated #126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Dhruv80576
Copy link
Contributor

@Dhruv80576 Dhruv80576 commented Oct 22, 2024

Fix #116
Enable google signin in firebase console.
Please find video of gauth integrated.

Screen_recording_20241021_185120.mp4

@Dhruv80576
Copy link
Contributor Author

Dhruv80576 commented Oct 24, 2024

@KirolosMFahem
Please review and merge it and add hacktoberfest and gssoc label

@KirolosMFahem KirolosMFahem added enhancement New feature or request gssoc-ext GSSOC contribution level2 GSSOC contribution level hacktoberfest-accepted hacktoberfest contribution PR hacktoberfest hacktoberfest contribution labels Oct 25, 2024
@KirolosMFahem
Copy link
Collaborator

The logs indicate that the job failed due to a formatting issue detected by dart_style. Specifically, the command dart run dart_style:format --dry-run --set-exit-if-changed . failed, indicating that some files are not properly formatted.

Error Explanation

  • The job runs a dry-run of the Dart formatter and sets an exit code if any files are not correctly formatted.
  • The specific error message is: Process completed with exit code 1, which occurs after running the formatter check.

Suggested Fix

  1. Run the Formatter Locally:

    • Run dart format . locally to automatically format your Dart files.
    • Commit the changes and push them to the repository.
  2. Check Specific Files:

    • The log mentions lib/firebase/auth.dart as one of the files involved. Make sure this file is properly formatted.

Steps to Fix

  1. Open Terminal:

    • Navigate to the root directory of your project.
  2. Run Dart Formatter:

    dart format .
  3. Commit Changes:

    git add .
    git commit -m "Fix formatting issues"
    git push origin <your-branch>

This should resolve the formatting-related issue and allow the GitHub Actions job to pass successfully.

Copy link
Collaborator

@KirolosMFahem KirolosMFahem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicting files

lib/pages/login_page.dart

@Dhruv80576
Copy link
Contributor Author

@KirolosMFahem
Merge conflicts resolved

Copy link
Collaborator

@KirolosMFahem KirolosMFahem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error log from the GitHub Actions job indicates the following issues:

  1. Extra Positional Arguments in lib/pages/login_page.dart:

    • Error: Too many positional arguments: 0 expected, but 2 found.
    • Fix: Review the function call on line 207 to ensure it matches the function's expected parameters.
  2. Missing Parenthesis in lib/pages/login_page.dart:

    • Error: Expected to find ')'.
    • Fix: Check the code around line 219 for any missing or unmatched parentheses.

Suggested Fixes:

  1. lib/pages/login_page.dart:
    • Correct the function call with too many positional arguments.
    • Ensure all parentheses are properly closed and matched.

Next Steps:

After making these corrections, DM me.

.signInWithGoogle(context: context);
},
icon: Image.asset("assets/images/google.png")),
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext GSSOC contribution hacktoberfest hacktoberfest contribution hacktoberfest-accepted hacktoberfest contribution PR level2 GSSOC contribution level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Integrating google oauth for easier authentication
2 participants