Track maximum runtime of currently running jobs #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative implementation of #13 without querying Redis.
The goal:
However, in implementation in #13 each Sidekiq worker executes query to Redis on each
collect
block execution, retrieves info about all executing jobs in all Sidekiq processes and single process reports not only its own stats, but also stats for every other worker. On large Sidekiq installations (with dozens processes executing hundreds of jobs at a time) it may be painful.In this pull request, every worker process keeps track and reports runtime duration only for its own jobs in memory and doesn't any additional requests to Redis.