add additional specific test for transformation of new null bubbling …

…from latest format
yaacovCR · Jan 14, 2025 · 462afcf · 462afcf
1 parent 2b4dac9
commit 462afcf
Show file tree

Hide file tree

Showing 2 changed files with 91 additions and 3 deletions.
diff --git a/src/transform/__tests__/legacyExecuteIncrementally-test.ts b/src/transform/__tests__/legacyExecuteIncrementally-test.ts
@@ -2,6 +2,11 @@ import { describe, it } from 'mocha';
 
 import { expectJSON } from '../../__testUtils__/expectJSON.js';
 
+import { invariant } from '../../jsutils/invariant.js';
+import { isPromise } from '../../jsutils/isPromise.js';
+import type { ObjMap } from '../../jsutils/ObjMap.js';
+
+import type { DocumentNode } from '../../language/ast.js';
 import { Kind } from '../../language/kinds.js';
 import { parse } from '../../language/parser.js';
 
@@ -10,14 +15,52 @@ import { GraphQLString } from '../../type/scalars.js';
 import { GraphQLSchema } from '../../type/schema.js';
 
 import { legacyExecuteIncrementally } from '../legacyExecuteIncrementally.js';
+import type {
+  LegacyInitialIncrementalExecutionResult,
+  LegacySubsequentIncrementalExecutionResult,
+} from '../transformResult.js';
+
+const someObjectType = new GraphQLObjectType({
+  name: 'SomeObject',
+  fields: {
+    someField: { type: GraphQLString },
+    anotherField: { type: GraphQLString },
+    nonNullableField: { type: new GraphQLNonNull(GraphQLString) },
+  },
+});
 
 const schema = new GraphQLSchema({
   query: new GraphQLObjectType({
     name: 'Query',
-    fields: { someField: { type: new GraphQLNonNull(GraphQLString) } },
+    fields: {
+      someField: { type: new GraphQLNonNull(GraphQLString) },
+      someObjectField: { type: someObjectType },
+    },
   }),
 });
 
+async function complete(document: DocumentNode, rootValue: ObjMap<unknown>) {
+  const result = legacyExecuteIncrementally({
+    schema,
+    document,
+    rootValue,
+  });
+
+  invariant(!isPromise(result));
+
+  if ('initialResult' in result) {
+    const results: Array<
+      | LegacyInitialIncrementalExecutionResult
+      | LegacySubsequentIncrementalExecutionResult
+    > = [result.initialResult];
+    for await (const patch of result.subsequentResults) {
+      results.push(patch);
+    }
+    return results;
+  }
+  return result;
+}
+
 describe('legacyExecuteIncrementally', () => {
   it('handles invalid document', () => {
     const result = legacyExecuteIncrementally({
@@ -52,4 +95,49 @@ describe('legacyExecuteIncrementally', () => {
       ],
     });
   });
+
+  it('handles null-bubbling from latest format', async () => {
+    const document = parse(`
+      query {
+        someObjectField {
+          ... @defer { someField anotherField }
+          ... @defer { someField nonNullableField }
+        }
+      }
+    `);
+    const result = await complete(document, {
+      someObjectField: {
+        someField: 'someField',
+        anotherField: 'anotherField',
+        nonNullableField: null,
+      },
+    });
+    expectJSON(result).toDeepEqual([
+      {
+        data: { someObjectField: {} },
+        hasNext: true,
+      },
+      {
+        incremental: [
+          {
+            data: { someField: 'someField', anotherField: 'anotherField' },
+            path: ['someObjectField'],
+          },
+          {
+            data: null,
+            errors: [
+              {
+                message:
+                  'Cannot return null for non-nullable field SomeObject.nonNullableField.',
+                locations: [{ line: 5, column: 11 }],
+                path: ['someObjectField', 'nonNullableField'],
+              },
+            ],
+            path: ['someObjectField'],
+          },
+        ],
+        hasNext: false,
+      },
+    ]);
+  });
 });
diff --git a/src/transform/completeValue.ts b/src/transform/completeValue.ts
@@ -119,10 +119,10 @@ export function completeSubValue(
   }
 
   invariant(isObjectLike(result));
-  return completeObjectType(context, errors, fieldDetailsList, result, path);
+  return completeObjectValue(context, errors, fieldDetailsList, result, path);
 }
 
-function completeObjectType(
+function completeObjectValue(
   context: TransformationContext,
   errors: Array<GraphQLError>,
   fieldDetailsList: ReadonlyArray<FieldDetails>,