FFI: Make variable encoding methods and schema match those of the existing CLP logging libraries; Add a version name for each. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CLP logging libraries; Add a version number for each.
davidlion
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing logging libraries (e.g., clp-logging) use different delimiters and encoding methods for variables. This commit switches to the same for consistency and assigns version names for bookkeeping. Note that the libraries use the compact variable encoding (4 bytes per encoded variable) whereas the FFI uses the standard variable encoding (8 bytes per encoded variable).
Validation performed
Verified the unit tests passed.