Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fix: Undo logic error in how database timestamp filtering criteria was set (fixes #69). #70

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

kirkrodrigues
Copy link
Member

References

#69

Description

  • The timestamp filtering criteria for filtering files from the database was flawed: It only returned files that fit entirely within the given timestamp range, rather than also returning those which partially overlapped with the given timestamp range.
  • This change fixes that and adds a comment so the next developer doesn't make the same silly mistake.

Validation performed

  • Compressed the dataset mentioned by the issue.
  • Verified the searches mentioned by the issue worked.
  • Verified that searches with a timestamp filter that overlapped with a certain file's timestamp range worked, no matter if it the overlap was a complete or partial.

@davidlion davidlion merged commit f17be1d into y-scope:main Aug 11, 2022
@kirkrodrigues kirkrodrigues deleted the fix-69 branch September 18, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants