clp-package: Add the log-viewer and serve it using the log-viewer-webui. #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhaoliao
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Thanks for the changes. Did we validate whether the YScope Log Viewer is accessible in the clp-package? i.e.,
cd <clp-root>/build/clp-package/sbin
./start-clp.sh
Then access localhost:3000/log-viewer/index.html and observe the Log Viewer is loaded.
(Let's also update the validation steps. )
junhaoliao
reviewed
Jul 22, 2024
Co-authored-by: Junhao Liao <[email protected]>
junhaoliao
reviewed
Jul 23, 2024
…odule reference to VCS.
junhaoliao
reviewed
Jul 23, 2024
components/clp-package-utils/clp_package_utils/scripts/start_clp.py
Outdated
Show resolved
Hide resolved
junhaoliao
reviewed
Jul 23, 2024
junhaoliao
reviewed
Jul 23, 2024
kirkrodrigues
requested changes
Jul 24, 2024
Co-authored-by: kirkrodrigues <[email protected]>
Co-authored-by: kirkrodrigues <[email protected]>
LOG_VIEWER_WEBUI_INNER_CLIENT_CHECKSUM_FILE -> LOG_VIEWER_CHECKSUM_FILE YSCOPE_LOG_VIEWER_OUTPUT_DIR -> LOG_VIEWER_OUTPUT_DIR inner-client -> log-viewer
junhaoliao
reviewed
Jul 24, 2024
kirkrodrigues
requested changes
Jul 24, 2024
kirkrodrigues
approved these changes
Jul 24, 2024
junhaoliao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate yscope-log-viewer to clp:
.gitmodules, putting it withinlog-viewer-webui.Taskfile.yml, create checksum and build tasks.Validation performed
Run
task package, the build should give no errors.In
clp/build/clp-package/sbin, runstart-clp.sh, access localhost:3000/log-viewer/index.html, observe log viewer is loaded.