Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clp-s: Add a comma after unstructured array fields during JSON serialization (fixes #410). #408

Merged
merged 1 commit into from
May 16, 2024

Conversation

wraymo
Copy link
Contributor

@wraymo wraymo commented May 15, 2024

References

#410

Description

The JSON serializer does not add a comma after an unstructured array field during decompression, which makes the decompressed log not in a valid JSON format. This PR fixes the bug.

Validation performed

Compressed the logs below and decompressed the archive

{"array":[1,2,3],"object":{"key":"value"}}
{"array":[4,5,6]}

Without the code change, the decompressed logs are

{"array":[1,2,3]"object":{"key":"value"}}
{"array":[4,5,6}

Now they are

{"array":[1,2,3],"object":{"key":"value"}}
{"array":[4,5,6]}

@kirkrodrigues kirkrodrigues requested a review from gibber9809 May 15, 2024 20:50
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with the commit message, but can we open an issue and add (fixes XXX) to the message?

@kirkrodrigues kirkrodrigues removed the request for review from gibber9809 May 15, 2024 21:10
@wraymo
Copy link
Contributor Author

wraymo commented May 15, 2024

Fine with the commit message, but can we open an issue and add (fixes XXX) to the message?

Sure

@wraymo wraymo changed the title clp-s: Add a comma after unstructured array fields during JSON serialization. clp-s: Add a comma after unstructured array fields during JSON serialization. (fixes #410) May 16, 2024
@wraymo wraymo changed the title clp-s: Add a comma after unstructured array fields during JSON serialization. (fixes #410) clp-s: Add a comma after unstructured array fields during JSON serialization (fixes #410). May 16, 2024
@wraymo wraymo merged commit 375261e into y-scope:main May 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants