Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Show total number of results instead of number of displayable results; Prompt users to refine search if they exhaust displayable results. #357

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

junhaoliao
Copy link
Member

@junhaoliao junhaoliao commented Apr 16, 2024

References

  1. webui: Add timeline for visualizing results of count-by-time aggregation; Replace Luxon with dayjs. #339 added count-by-time search aggregation support into webui but did not update the total number of results displayed in the results header.

Description

  1. Show total num results instead of result cache count.
  2. Prompt users to refine filters when there are more results.

Validation performed

  1. Temporarily changed SEARCH_MAX_NUM_RESULTS -> 20.
    const SEARCH_MAX_NUM_RESULTS = 1000;
  2. Rebuilt clp package.
  3. cd built/clp-package/sbin
  4. ./start-clp.sh
  5. ./compress.sh ~/samples/hive-24hr/
  6. Launched WebUI and started a query with search string 1.
  7. Observed the query completed and the "Result count" shown as 6224074 above the header.
  8. Kept scrolling down till all results in the cache are shown. A message appeared at the bottom of the search results table as:
    Results limit 20 reached. Please refine the filters to display additional matches.
    

…sers to refine filters when there are more results.
@junhaoliao junhaoliao requested review from kirkrodrigues and wraymo and removed request for kirkrodrigues April 16, 2024 05:19
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webui: Show total number of results instead of number of displayable results; Prompt users to refine search if they exhaust displayable results. (#357)

?

@junhaoliao junhaoliao changed the title webui: Show total num results instead of result cache count; Prompt users to refine filters when there are more results. webui: Show total number of results instead of number of displayable results; Prompt users to refine search if they exhaust displayable results. Apr 25, 2024
@junhaoliao junhaoliao merged commit d6919bf into y-scope:main Apr 25, 2024
1 check passed
@junhaoliao junhaoliao deleted the webui-total-count branch April 25, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants