-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui: Integrate eslint-config-yscope
and refactor accordingly.
#351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jsx` to avoid explicit `React` imports.
…ts` absolute path.
Co-authored-by: kirkrodrigues <[email protected]>
…d unnecessary nesting in imports.
…d unnecessary nesting in imports. !2
…or setting timeline cursor.
…ame source files whose have same name as its parent folder to avoid unnecessary nesting in imports. !3
kirkrodrigues
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more small changes.
components/webui/imports/ui/SearchView/SearchResults/SearchResultsTimeline/index.jsx
Outdated
Show resolved
Hide resolved
...orts/ui/SearchView/SearchControls/SearchControlsFilterDrawer/SearchControlsFilterDrawer.scss
Outdated
Show resolved
Hide resolved
...ls/SearchControlsFilterDrawer/SearchControlsTimeRangeInput/SearchControlsTimeRangeInput.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: kirkrodrigues <[email protected]>
Co-authored-by: kirkrodrigues <[email protected]>
Co-authored-by: kirkrodrigues <[email protected]>
kirkrodrigues
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
webui: Integrate eslint-config-yscope
and refactor accordingly. (#351)
eslint-config-yscope
and refactor.eslint-config-yscope
and refactor accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Internal discussions concluded that
eslint-config-yscope
shall be integrated to aid development process.Description
eslint-config-yscope
.@babel/plugin-transform-react-jsx
to avoid explicitReact
imports; Remove.jsx
extensions fromimport
statements.18.2.0
and replace deprecatedimport("react-dom").render()
withReactDOM.createRoot(...).render()
.App.scss
.Roboto Mono
for search result table row texts.Source Sans Pro
withSource Sans 3
and upgrade the fetching fonts.googleapis to v2.meteortesting:mocha
to.meteor/packages
to avoid related dependencies determined "unused" and got removed when meteor starts.Validation performed
clp-package
.components/webui/README.md
to install Node.js dependencies for running the linter.server/main.js
. Ran newly added linting scripts inpackage.json
:npm run lint:check
:npm run lint:fix
:npm run lint
(alias ofnpm run lint:check
):