-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui: Add table to display the status of recent ingestion jobs. #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # components/clp-package-utils/clp_package_utils/scripts/start_clp.py # components/webui/imports/api/ingestion/collections.js # components/webui/imports/api/ingestion/server/publications.js # components/webui/imports/api/search/constants.js # components/webui/imports/api/search/server/publications.js # components/webui/imports/ui/IngestView/IngestView.jsx # components/webui/imports/ui/SearchView/SearchResultsTable.jsx # components/webui/imports/ui/SearchView/SearchView.jsx # components/webui/imports/utils/DbManager.js # components/webui/server/main.js # components/webui/settings.json
…m the compression job.
kirkrodrigues
requested changes
Apr 21, 2024
components/webui/imports/api/ingestion/server/CompressionDbManager.js
Outdated
Show resolved
Hide resolved
components/webui/imports/api/ingestion/server/CompressionDbManager.js
Outdated
Show resolved
Hide resolved
components/webui/imports/api/ingestion/server/CompressionDbManager.js
Outdated
Show resolved
Hide resolved
components/webui/imports/api/ingestion/server/CompressionDbManager.js
Outdated
Show resolved
Hide resolved
components/webui/imports/api/ingestion/server/CompressionDbManager.js
Outdated
Show resolved
Hide resolved
components/webui/imports/ui/IngestView/panels/IngestionJobs/index.jsx
Outdated
Show resolved
Hide resolved
components/webui/imports/ui/IngestView/panels/IngestionJobs/IngestionJobRow.jsx
Outdated
Show resolved
Hide resolved
components/webui/imports/ui/IngestView/panels/IngestionJobs/IngestionJobRow.jsx
Outdated
Show resolved
Hide resolved
components/webui/imports/ui/IngestView/panels/IngestionJobs/IngestionJobRow.jsx
Outdated
Show resolved
Hide resolved
components/webui/imports/ui/IngestView/panels/IngestionJobs/IngestionJobRow.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: kirkrodrigues <[email protected]>
Co-authored-by: kirkrodrigues <[email protected]>
kirkrodrigues
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
webui: Add table to display the status of recent ingestion jobs. (#350)
<CompressionJobTable/>
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Compression job statuses are currently only displayed to users by the
compress.sh
script.Description
This PR adds a Compression Job Table in Ingestion View and the corresponding backend handling. The changes should also improve User Experience for tracking S3 job submissions, which is not yet ported to this repository.
Validation performed
clp-package
.0.00%
because no file has been compressed../compress.sh ~/samples/hive-24hr/
to compress sample logs. Observed the compression job table showed up as the compression job quickly finished and the compression stats showed up as well../compress.sh non-existent-path
. Observed the job record showed up in the table and hovering on the failure icon show a brief reason for the failure: