-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reducer server for performing aggregation operations. #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An incomplete review but something to start with.
Besides the inline comments (in order of priority):
- Add class docstrings.
- Fix most (if not all) of the clang-tidy warnings (using the clang-tidy config I gave you).
- Add method docstrings for non-trivial public methods.
- Add method docstrings for non-trivial private methods.
…ty to ServerContext.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished a pass on the code. Can you address the unresolved comments and then test everything?
Tested that everything works end to end after my most recent set of changes. |
|
||
// Validate arguments | ||
if (m_reducer_host.empty()) { | ||
throw std::invalid_argument("reducer-host cannot be empty."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to catch the exceptions here or in main
, right? Otherwise main
will throw which is no bueno. My preference would be to catch them here like we do in the other programs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit msg: Add a reducer server for performing aggregation operations. (#221)
?
Dropped "distributed" since it might imply that the reducer itself is distributed, but no big deal if you want to keep it in.
Description
Adds a heavily refactored version of the reducer server from the prototype distributed setup as well as the code necessary to construct local in memory reduction pipelines.
Validation performed