Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building clp-core on macOS #105

Merged
merged 4 commits into from
Feb 19, 2023

Conversation

kirkrodrigues
Copy link
Member

Description

This PR adds some compilation fixes and platform-specific code to build CLP's core on macOS; in addition, it adds a GitHub workflow job to test building CLP's core on macOS 12.

Each step is split up into a different commit.

Validation performed

  • Built all CLP core executables on macOS.
  • Validated compression, decompression, and search of the openstack-24hr dataset.

* Only look for static library dependencies if we're building with static linking.
* Disable static linking on macOS (unsupported).
* Link against c++fs if required by the compiler that's being used.
…between the two; Replace __mode_t with mode_t.
@davidlion davidlion merged commit 52a57b2 into y-scope:main Feb 19, 2023
@kirkrodrigues kirkrodrigues deleted the macos-core-build branch February 19, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants