Apply suggestions from code review

Co-authored-by: kirkrodrigues <[email protected]>

components/clp-py-utils/clp_py_utils/clp_config.py

@@ -417,7 +417,7 @@ class StreamS3Storage(S3Storage):
 
 def _get_directory_from_storage_config(storage_config: Union[FsStorage, S3Storage]) -> pathlib.Path:
     storage_type = storage_config.type
-    if StorageType.FS == storage_config.type:
+    if StorageType.FS == storage_type:
         return storage_config.directory
     elif StorageType.S3 == storage_type:
         return storage_config.staging_directory
@@ -600,7 +600,7 @@ def validate_stream_output_dir(self):
         try:
             validate_path_could_be_dir(self.stream_output.get_directory())
         except ValueError as ex:
-            raise ValueError(f"stream_output.directory is invalid: {ex}")
+            raise ValueError(f"stream_output.storage's directory is invalid: {ex}")
 
     def validate_data_dir(self):
         try:

components/core/src/clp/clo/CommandLineArguments.cpp

@@ -188,7 +188,7 @@ auto CommandLineArguments::parse_ir_extraction_arguments(
     )(
             "print-ir-stats",
             po::bool_switch(&m_print_ir_stats),
-            "Print statistics (ndjson) about each IR file as it's extracted"
+            "Print statistics (ndjson) about each IR file after it's extracted"
     );
     // clang-format on
 

components/job-orchestration/job_orchestration/executor/query/extract_stream_task.py

@@ -183,6 +183,9 @@ def extract_stream(
 
             stream_path = Path(stream_path_str)
 
+            # If we've had a single upload error, we don't want to try uploading any other streams
+            # since that may unnecessarily slow down the task and generate a lot of extraneous
+            # output.
             if not upload_error:
                 stream_name = stream_path.name
                 logger.info(f"Uploading stream {stream_name} to S3...")