Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yrs to 0.19 #8

Closed
wants to merge 1 commit into from
Closed

Update yrs to 0.19 #8

wants to merge 1 commit into from

Conversation

rbtying
Copy link

@rbtying rbtying commented Jul 8, 2024

Updates yrs to 0.19

@Horusiath
Copy link
Collaborator

I'll need to address some improvements here before releasing the next version.

@Horusiath
Copy link
Collaborator

@rbtying I've made upgrade in #9, but after running tests on macOS it looks like there are some issues about how rocksdb TransactionDB::open_default is initialised.

unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap
stack backtrace:
   0: rust_begin_unwind
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/std/src/panicking.rs:652:5
   1: core::panicking::panic_nounwind_fmt::runtime
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panicking.rs:110:18
   2: core::panicking::panic_nounwind_fmt
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panicking.rs:120:5
   3: core::panicking::panic_nounwind
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panicking.rs:220:5
   4: core::intrinsics::copy_nonoverlapping::precondition_check
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ub_checks.rs:66:21
   5: core::intrinsics::copy_nonoverlapping
             at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ub_checks.rs:73:17
   6: rocksdb::transactions::transaction_db::TransactionDB<T>::open_cf_descriptors_internal
             at /Users/bartoszsypytkowski/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocksdb-0.22.0/src/transactions/transaction_db.rs:303:13
   7: rocksdb::transactions::transaction_db::TransactionDB<T>::open_cf
             at /Users/bartoszsypytkowski/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocksdb-0.22.0/src/transactions/transaction_db.rs:200:9
   8: rocksdb::transactions::transaction_db::TransactionDB<T>::open
             at /Users/bartoszsypytkowski/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocksdb-0.22.0/src/transactions/transaction_db.rs:179:9
   9: rocksdb::transactions::transaction_db::TransactionDB<T>::open_default
             at /Users/bartoszsypytkowski/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocksdb-0.22.0/src/transactions/transaction_db.rs:170:9

I need to make sure if this problem only occurs in our case or is this some general issue that happens in recent Rust version for rocksdb crate.

@rbtying
Copy link
Author

rbtying commented Jul 9, 2024

@Horusiath looks like a rocksdb issue?

rust-rocksdb/rust-rocksdb#881

@rbtying rbtying closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants