Bump version to create github v0.5.8 release and upload pypi wheels? #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also just saw @davidbrochart comment #119 (comment) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v0.5.7 github release built wheels correctly (thank goodness, finally) but parts of the push to pypi failed because pyproject.toml version was still 0.5.5 and there were wheels on pypi for 0.5.5 already https://github.com/y-crdt/ypy/actions/runs/4188025953/jobs/7259030230. There are now some y_py 0.5.5 wheels uploaded Dec 13 2022 and (the new aarch64) wheels uploaded Feb 15 2023 https://pypi.org/project/y-py/0.5.5/#files.
One option is to bump the version in pyproject.toml from 0.5.5 to 0.5.8 so that we don't have to delete and recreate releases in github -- there would just be "missing" wheels on p ypi for 0.5.6 / 0.5.7. @Waidhoferj I'm also fine if you want to close this PR, delete the previous github releases, bump pyproject.toml to 0.5.6 and recreate the github v0.5.6 release.
Thanks.