-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build aarch64 take 2 #119
Merged
Merged
Build aarch64 take 2 #119
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ name: Build and Release | |
| on: | ||
| release: | ||
| types: [published] | ||
| pull_request: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
|
|
@@ -14,35 +15,31 @@ env: | |
| jobs: | ||
| macos: | ||
| runs-on: macos-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: | ||
| - '3.7' | ||
| - '3.8' | ||
| - '3.9' | ||
| - '3.10' | ||
| - '3.11' | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-python@v2 | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| python-version: '3.11' | ||
| architecture: x64 | ||
| - name: Install Rust toolchain | ||
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| profile: minimal | ||
| default: true | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| - name: Build wheels - x86_64 | ||
| uses: messense/maturin-action@v1 | ||
| uses: PyO3/maturin-action@v1 | ||
| with: | ||
| target: x86_64 | ||
| args: --release --out dist --sdist --find-interpreter | ||
| args: --release --out dist --sdist -i 3.7 3.8 3.9 3.10 3.11 pypy3.8 pypy3.9 | ||
| - name: Test built wheel - x86_64 | ||
| run: | | ||
| pip install y-py --no-index --find-links dist --force-reinstall | ||
| pip install pytest | ||
| pytest | ||
| - name: Build wheels - universal2 | ||
| uses: messense/maturin-action@v1 | ||
| uses: PyO3/maturin-action@v1 | ||
| with: | ||
| args: --release --universal2 --out dist --find-interpreter | ||
| args: --release --universal2 --out dist -i 3.8 3.9 3.10 3.11 pypy3.8 pypy3.9 | ||
| - name: Test built wheel - universal2 | ||
| run: | | ||
| pip install y-py --no-index --find-links dist --force-reinstall | ||
| pytest | ||
| - name: Upload wheels | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
|
|
@@ -51,32 +48,31 @@ jobs: | |
|
|
||
| windows: | ||
| runs-on: windows-latest | ||
| name: windows (${{ matrix.platform.target }}) | ||
| strategy: | ||
| matrix: | ||
| target: [x64, x86] | ||
| python-version: | ||
| - '3.7' | ||
| - '3.8' | ||
| - '3.9' | ||
| - '3.10' | ||
| - '3.11' | ||
| platform: | ||
| - target: x64 | ||
| interpreter: 3.7 3.8 3.9 3.10 3.11 | ||
| - target: x86 | ||
| interpreter: 3.7 3.8 3.9 3.10 3.11 | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-python@v2 | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| architecture: ${{ matrix.target }} | ||
| - name: Install Rust toolchain | ||
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| profile: minimal | ||
| default: true | ||
| python-version: '3.11' | ||
| architecture: ${{ matrix.platform.target }} | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| - name: Build wheels | ||
| uses: messense/maturin-action@v1 | ||
| uses: PyO3/maturin-action@v1 | ||
| with: | ||
| target: ${{ matrix.target }} | ||
| args: --release --out dist --find-interpreter | ||
| target: ${{ matrix.platform.target }} | ||
| args: --release --out dist -i ${{ matrix.platform.interpreter }} | ||
| - name: Test built wheel | ||
| run: | | ||
| pip install y-py --no-index --find-links dist --force-reinstall | ||
| pip install pytest | ||
| pytest | ||
| - name: Upload wheels | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
|
|
@@ -88,24 +84,25 @@ jobs: | |
| strategy: | ||
| matrix: | ||
| target: [x86_64, i686] | ||
| python-version: | ||
| - '3.7' | ||
| - '3.8' | ||
| - '3.9' | ||
| - '3.10' | ||
| - '3.11' | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-python@v2 | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| architecture: ${{ matrix.target }} | ||
| python-version: '3.11' | ||
| architecture: x64 | ||
| - name: Build wheels | ||
| uses: messense/maturin-action@v1 | ||
| uses: PyO3/maturin-action@v1 | ||
| with: | ||
| rust-toolchain: stable | ||
| target: ${{ matrix.target }} | ||
| manylinux: auto | ||
| args: --release --out dist --find-interpreter | ||
| args: --release --out dist -i 3.7 3.8 3.9 3.10 3.11 pypy3.8 pypy3.9 | ||
| - name: Test built wheel | ||
| if: matrix.target == 'x86_64' | ||
| run: | | ||
| pip install y-py --no-index --find-links dist --force-reinstall | ||
| pip install pytest | ||
| pytest | ||
| - name: Upload wheels | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
|
|
@@ -116,28 +113,40 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: | ||
| - '3.7' | ||
| - '3.8' | ||
| - '3.9' | ||
| - '3.10' | ||
| - '3.11' | ||
| target: [aarch64, armv7, s390x, ppc64le] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Build Wheels | ||
| uses: PyO3/maturin-action@v1 | ||
| with: | ||
| target: ${{ matrix.target }} | ||
| manylinux: auto | ||
| args: -i ${{ matrix.python-version }} --release --out dist | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.11' | ||
| - name: Build wheels | ||
| uses: PyO3/maturin-action@v1 | ||
| with: | ||
| rust-toolchain: stable | ||
| target: ${{ matrix.target }} | ||
| manylinux: auto | ||
| args: --release --out dist -i 3.7 3.8 3.9 3.10 3.11 pypy3.8 pypy3.9 | ||
|
|
||
| - uses: uraimo/[email protected] | ||
| if: matrix.target != 'ppc64' | ||
| name: Test built wheel | ||
| with: | ||
| arch: ${{ matrix.target }} | ||
| distro: ubuntu20.04 | ||
| githubToken: ${{ github.token }} | ||
| install: | | ||
| apt-get update | ||
| apt-get install -y --no-install-recommends python3 python3-pip | ||
| pip3 install -U pip pytest | ||
| run: | | ||
| pip3 install y-py --no-index --find-links dist/ --force-reinstall | ||
| pytest | ||
|
|
||
| - name: Upload wheels | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: wheels | ||
| path: dist | ||
| - name: Upload wheels | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: wheels | ||
| path: dist | ||
|
|
||
| wasm: | ||
| runs-on: ubuntu-20.04 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kafonek before trying the deploy, is there a reason that we trigger the wheel build on PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goal here is to raise some of the errors we've been seeing before getting to a release action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a bit overkill to run it on every PR, since we only need to check on PRs immediately before a release. Maybe we could use
workflow_dispatchinstead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to using that and manually kicking off actions if you want to add me to the repo with write access 🙏 I feel bad that there's so many release action failures based on some CI PR's I've put in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate the work you put into this. Wish it wasn't so hard to verify. Unfortunately, I don't have control over read/write access to the repo, but I think @dmonad can help with this.