Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rename rememberViewModel to be architecture agnostic #5

Merged
merged 3 commits into from
May 10, 2023

Conversation

xxfast
Copy link
Owner

@xxfast xxfast commented May 9, 2023

The word ViewModels is a misnomer, and may be confusing if you don't want to implement MVVM. The responsibility of this instance is ultimately up to the developer (a view model, a state-holder, domain or whatever) but the only responsibility of this navigation library is to

  1. Makes your instances survive configuration changes (on Android) 🔁
  2. Hold on to the instance as long as it is in the backstack 🔗

Hopefullty this name rememberOnRoute will make things more straightforward. Coincidently it mirrors the name rememberRouter

@xxfast xxfast force-pushed the ir/remove-viewmodel branch from aecd48a to 057f917 Compare May 9, 2023 05:02
@xxfast xxfast merged commit 1b94525 into main May 10, 2023
@xxfast xxfast deleted the ir/remove-viewmodel branch May 10, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant