Display an error when attachment can't be loaded.

Message needs more work. See #27 (comment) 04
xwp · Mar 17, 2017 · ce4890c · ce4890c
1 parent 27d0d04
commit ce4890c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/wp-admin/js/widgets/media-widgets.js b/wp-admin/js/widgets/media-widgets.js
@@ -152,9 +152,13 @@ wp.mediaWidgets = ( function( $ ) {
 				attachment = new wp.media.model.Attachment( {
 					id: control.model.get( 'attachment_id' )
 				} );
-				attachment.fetch().done( function() {
-					control.selectedAttachment.set( attachment.attributes );
-				} );
+				attachment.fetch()
+					.done( function() {
+						control.selectedAttachment.set( attachment.attributes );
+					} )
+					.fail( function() {
+						control.selectedAttachment.set( { error: true } );
+					} );
 			}
 		},
 

diff --git a/wp-includes/widgets/class-wp-widget-image.php b/wp-includes/widgets/class-wp-widget-image.php
@@ -33,6 +33,7 @@ public function __construct() {
 			'edit_media' => __( 'Edit Image' ),
 			'change_media' => __( 'Change Image' ),
 			'select_media' => __( 'Select Image' ),
+			'error' => __( 'Image could not be loaded. Please verify it was not deleted.' ),
 		) );
 	}
 
@@ -266,6 +267,10 @@ public function render_control_template_scripts() {
 				<img class="attachment-thumb" src="{{ data.attachment.sizes.medium.url }}" draggable="false" alt="" />
 			<# } else if ( 'image' === data.attachment.type && data.attachment.sizes && data.attachment.sizes.full ) { #>
 				<img class="attachment-thumb" src="{{ data.attachment.sizes.full.url }}" draggable="false" alt="" />
+			<# } else if ( data.attachment.error ) { #>
+				<div class="notice notice-error notice-alt">
+					<p><?php echo esc_html( $this->l10n['error'] ); ?></p>
+				</div>
 			<# } #>
 		</script>
 		<?php