Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/dispose on qr controller #6

Closed
wants to merge 4 commits into from
Closed

Improvement/dispose on qr controller #6

wants to merge 4 commits into from

Conversation

freitzzz
Copy link
Contributor

see #5

@freitzzz freitzzz mentioned this pull request Sep 25, 2020
Closed
@xuzhongpeng xuzhongpeng marked this pull request as ready for review September 27, 2020 05:47
@freitzzz
Copy link
Contributor Author

@xuzhongpeng can you consider this PR again? We have a security issue in iOS 14 because once the qr code is built, a green dot indicating that the camera is being used stays on until the app is closed.

This is most likely fixed if we are able to stop running the AVCapture session

@xuzhongpeng
Copy link
Owner

xuzhongpeng commented Nov 12, 2020 •
edited
Loading

@xuzhongpeng can you consider this PR again? We have a security issue in iOS 14 because once the qr code is built, a green dot indicating that the camera is being used stays on until the app is closed.

This is most likely fixed if we are able to stop running the AVCapture session

I will check the problem as soon. If you can provide more information, such as your iPhone model. I'd be grateful

@freitzzz
Copy link
Contributor Author

@xuzhongpeng can you consider this PR again? We have a security issue in iOS 14 because once the qr code is built, a green dot indicating that the camera is being used stays on until the app is closed.
This is most likely fixed if we are able to stop running the AVCapture session

I will check the problem as soon. If you can provide more information, such as your iPhone model. I'd be grateful

We were able to fix the issue by calling pause.

iPhone Xr, version >= 14

@xuzhongpeng
Copy link
Owner

@xuzhongpeng can you consider this PR again? We have a security issue in iOS 14 because once the qr code is built, a green dot indicating that the camera is being used stays on until the app is closed.
This is most likely fixed if we are able to stop running the AVCapture session

I will check the problem as soon. If you can provide more information, such as your iPhone model. I'd be grateful

We were able to fix the issue by calling pause.

iPhone Xr, version >= 14

fixed in 1.0.9

@freitzzz
Copy link
Contributor Author

@xuzhongpeng can you consider this PR again? We have a security issue in iOS 14 because once the qr code is built, a green dot indicating that the camera is being used stays on until the app is closed.
This is most likely fixed if we are able to stop running the AVCapture session

I will check the problem as soon. If you can provide more information, such as your iPhone model. I'd be grateful

We were able to fix the issue by calling pause.
iPhone Xr, version >= 14

fixed in 1.0.9

Thank you, will test and then give feedback :)

@freitzzz freitzzz closed this Nov 30, 2020
@freitzzz freitzzz deleted the improvement/dispose-on-qr-controller branch November 30, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holofox Holofox Holofox left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freitzzz @xuzhongpeng @Holofox