feat: unified api #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wei
reviewed
Oct 22, 2017
| // 如果只有一个 tag 则没法对比，忽略 | ||
| if (tags.length < 2) { | ||
| return | ||
| } |
There was a problem hiding this comment.
如果只有一个 tag 可以和 initial commit 对比呀。
There was a problem hiding this comment.
是的，不过 github api 需要调用 https://api.github.com/repos/xuexb/github-bot/commits 且来获取 response.header.Link 中的 last 再去获取该接口的第一个 commit ，步骤比较繁琐，下个 PR 里修复下吧~
yugasun
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[]或者nulltrue，失败则返回falsegit clone方式的代码