ClangTidy fixes for common_audio/

These are manual edits please verify there are no typos. Feel free to auto-submit if there are no issues. Bug: webrtc:10410 Change-Id: If995d9d9d21534d3c66a1e7c1fc1c62569766f40 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127627 Commit-Queue: Benjamin Wright <[email protected]> Reviewed-by: Karl Wiberg <[email protected]> Cr-Commit-Position: refs/heads/master@{#27138}
xuandu · Mar 15, 2019 · 8965fbc · 8965fbc
1 parent c6fa6d9
commit 8965fbc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/common_audio/audio_converter.cc b/common_audio/audio_converter.cc
@@ -20,8 +20,6 @@
 #include "rtc_base/checks.h"
 #include "rtc_base/numerics/safe_conversions.h"
 
-using rtc::checked_cast;
-
 namespace webrtc {
 
 class CopyConverter : public AudioConverter {

diff --git a/common_audio/sparse_fir_filter.cc b/common_audio/sparse_fir_filter.cc
@@ -45,7 +45,7 @@ void SparseFIRFilter::Filter(const float* in, size_t length, float* out) {
   }
 
   // Update current state.
-  if (state_.size() > 0u) {
+  if (!state_.empty()) {
     if (length >= state_.size()) {
       std::memcpy(&state_[0], &in[length - state_.size()],
                   state_.size() * sizeof(*in));

diff --git a/common_audio/wav_header.cc b/common_audio/wav_header.cc
@@ -122,7 +122,7 @@ void FindWaveChunk(ChunkHeader* chunk_header,
     if (!readable->SeekForward(chunk_header->Size))
       return;  // EOF or error.
   }
-  return;  // EOF.
+  // EOF.
 }
 
 bool ReadFmtChunkData(FmtSubchunk* fmt_subchunk, ReadableWav* readable) {