Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix impsort mvn 391 #544

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix impsort mvn 391 #544

merged 1 commit into from
Apr 27, 2023

Conversation

mnovak1
Copy link
Contributor

@mnovak1 mnovak1 commented Apr 27, 2023

plexus is no longer injected by maven

https://maven.apache.org/docs/3.9.1/release-notes.html

Maven 2.x was auto-injecting an ancient version of plexus-utils dependency into the plugin classpath, and Maven 3.x continued doing this to preserve backward compatibility. Starting with Maven 3.9, it does not happen anymore. This change may lead to plugin breakage. The fix for affected plugin maintainers is to explicitly declare a dependency on plexus-utils. The workaround for affected plugin users is to add this dependency to plugin dependencies until issue is fixed by the affected plugin maintainer. See MNG-6965.

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

@mnovak1 mnovak1 mentioned this pull request Apr 27, 2023
4 tasks
@mnovak1 mnovak1 force-pushed the fix-impsort-mvn-391 branch from cf55d87 to 45fe0d3 Compare April 27, 2023 12:22
@mnovak1
Copy link
Contributor Author

mnovak1 commented Apr 27, 2023

@simkam I've force pushed the PR as I left a mess there.

@mnovak1
Copy link
Contributor Author

mnovak1 commented Apr 27, 2023

I'll merge it once all checks passes.

@mnovak1 mnovak1 merged commit d84bd07 into xtf-cz:master Apr 27, 2023
@simkam
Copy link
Contributor

simkam commented Apr 27, 2023

ha, I thought it is intentional ... ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants