Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HELM_KUBEASUSER removal #542

Merged
merged 1 commit into from
Apr 26, 2023
Merged

HELM_KUBEASUSER removal #542

merged 1 commit into from
Apr 26, 2023

Conversation

spriadka
Copy link
Contributor

I have found out that combining HELM_KUBEASUSER and KUBETOKEN does not work well with masterBinary. Removing HELM_KUBEASUSER seems to solve the issue

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

@spriadka spriadka mentioned this pull request Apr 25, 2023
Closed
@mnovak1
Copy link
Contributor

mnovak1 commented Apr 26, 2023

LGTM

Looks like that HELM_KUBEASUSER is not needed at all. There is also no "password" based authentication (https://helm.sh/docs/helm/helm/).

@mnovak1 mnovak1 merged commit 649abf1 into xtf-cz:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnovak1 mnovak1 mnovak1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spriadka @mnovak1