Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refractor code using spotless #530

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

refractor code using spotless #530

wants to merge 1 commit into from

Conversation

laDok8
Copy link
Contributor

@laDok8 laDok8 commented Feb 28, 2023

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

adding spotless plugin for code formatting
this PR contributes to #529

@laDok8 laDok8 requested a review from mnovak1 February 28, 2023 12:21
@laDok8 laDok8 marked this pull request as draft February 28, 2023 12:23
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 28, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@laDok8
Copy link
Contributor Author

laDok8 commented Feb 28, 2023

changes made by spotless should be +- equivalent to java formatter with these args: --skip-sorting-imports --aosp
so we could use GHA for feature parity or simply setup our own with mvn spotless:check

@laDok8 laDok8 marked this pull request as ready for review February 28, 2023 14:04
@laDok8 laDok8 marked this pull request as draft March 1, 2023 09:44
@laDok8 laDok8 force-pushed the refractor branch 3 times, most recently from d414034 to 2307447 Compare March 1, 2023 10:13
@tommaso-borgato tommaso-borgato added this to the BACKLOG milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnovak1 mnovak1 Awaiting requested review from mnovak1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
BACKLOG
Development

Successfully merging this pull request may close these issues.
2 participants
@laDok8 @tommaso-borgato