Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useFlowControl option #513

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Add useFlowControl option #513

merged 1 commit into from
Jan 27, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 27, 2017

Fixes #511

@Tyriar Tyriar added this to the 2.3.0 milestone Jan 27, 2017
@Tyriar Tyriar self-assigned this Jan 27, 2017
@Tyriar Tyriar requested a review from parisk January 27, 2017 05:14
parisk
parisk approved these changes Jan 27, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mofux
Copy link
Contributor

mofux commented Jan 27, 2017

Out of curiosity, what was the reason to disable flow control by default?

@mofux
Copy link
Contributor

mofux commented Jan 27, 2017

Found the answer in #511, seems reasonable.

@Tyriar Tyriar merged commit 365a9f9 into xtermjs:master Jan 27, 2017
@Tyriar Tyriar deleted the 511_useFlowControl_option branch January 27, 2017 16:23
@Tyriar Tyriar modified the milestone: 2.3.0 Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @mofux @parisk