Make xterm.js multi-window aware #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue this aims to solve is that xterm.js doesn't know when the window of
Terminal.elementchanges and as such does not react to it. The main problem this causes isdevicePixelRatiodoesn't update when switching between monitors with different OS scaling, but there may be other problems with using "stale" windows as well. Note that this is only an issue if moving an xterm.js instance that was already opened into a new window, not if a new instance was created in a sub-window like how the client.ts button works.See microsoft/vscode#195577