Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move addon install to presetup #4710

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Move addon install to presetup #4710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee33765
Move addon install to presetup
Tyriar Aug 22, 2023
eae79e9
Install addons in CI
Tyriar Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ jobs:
node-version: 18.x
cache: 'yarn'
- name: Install dependencies
run: yarn --frozen-lockfile
run: |
yarn --frozen-lockfile
yarn install-addons
- name: Lint code
run: yarn lint
- name: Lint API
Expand Down Expand Up @@ -95,15 +97,17 @@ jobs:
node-version: ${{ matrix.node-version }}.x
cache: 'yarn'
- name: Install dependencies
run: yarn --frozen-lockfile
run: |
yarn --frozen-lockfile
yarn install-addons
- name: Unit tests
run: yarn test-unit --forbid-only

integration-tests:
needs: build
strategy:
matrix:
node-version: [18]
node-version: [18] # just one as integration tests are about testing in browser
runs-on: [ubuntu, windows] # macos is flaky
browser: [chromium, firefox]
runs-on: ${{ matrix.runs-on }}-latest
Expand All @@ -126,7 +130,9 @@ jobs:
node-version: ${{ matrix.node-version }}.x
cache: 'yarn'
- name: Install dependencies
run: yarn --frozen-lockfile
run: |
yarn --frozen-lockfile
yarn install-addons
- name: Install playwright
run: npx playwright install
- name: Integration tests (${{ matrix.browser }})
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@
"test-unit-coverage": "node ./bin/test.js --coverage",
"test-unit-dev": "cross-env NODE_PATH='./out' mocha",
"build": "tsc -b ./tsconfig.all.json",
"install-addons": "node ./bin/install-addons.js",
"presetup": "npm run install-addons",
"setup": "npm run build",
"postinstall": "node ./bin/install-addons.js",
"postsetup": "npm run inwasm",
"prepublishOnly": "npm run package",
"watch": "tsc -b -w ./tsconfig.all.json --preserveWatchOutput",
Expand Down