pull AccessibleBuffer out of AccessibilityManager
#4400
Conversation
| @@ -576,6 +578,8 @@ export class Terminal extends CoreTerminal implements ITerminal { | |||
| // Listen for mouse events and translate | |||
| // them into terminal mouse protocols. | |||
| this.bindMouse(); | |||
|
|
|||
There was a problem hiding this comment.
I had to put this here so that dimensions from the render service wouldn't be 0. lmk if there's a better place
There was a problem hiding this comment.
This is the right function, I'd put it just below the AccessibilityManagers init to be a little more organized. If you needed to move it here then something must not have been migrated to the new file correctly as it was working before when bundled into AccessibilityManager.
Unless that only worked when toggling screenReaderMode on after Terminal was opened? In that case there's probably some other event we're not listening to?
There was a problem hiding this comment.
that's where I put it originally and it didn't work, so seems like we're missing something
There was a problem hiding this comment.
it needs to be after this to work
this._charSizeService.measure();
This reverts commit 6daadc4.
Not sure where the code that makes
Shift Tabenter this mode is, but it doesn't work when not using screen reader mode. Perhaps that's fine though and will leave it up to the embedders