Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cols/rows only usable in the ctor #3960

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Make cols/rows only usable in the ctor #3960

merged 1 commit into from
Jul 29, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 28, 2022

Fixes #3825

@Tyriar Tyriar added the breaking-change Breaks API and requires a major version bump label Jul 28, 2022
@Tyriar Tyriar added this to the 5.0.0 milestone Jul 28, 2022
@Tyriar Tyriar self-assigned this Jul 28, 2022
@Tyriar Tyriar merged commit 7f5ed40 into xtermjs:master Jul 29, 2022
@Tyriar Tyriar deleted the init_options branch July 29, 2022 14:20
This was referenced Jul 30, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
breaking-change Breaks API and requires a major version bump
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Getting rows/cols via getOption/options is misleading
1 participant
@Tyriar