Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct start col/row in next search #3707

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge commented Mar 23, 2022

I believe the search results were incomplete because when a result started on the last col, incrementing col by 1 resulted in an invalid place to begin the next search, so no result would be found and it would return

Fixes #3706

@meganrogge meganrogge requested a review from Tyriar March 23, 2022 17:57
@meganrogge meganrogge self-assigned this Mar 23, 2022
@meganrogge meganrogge added this to the 4.19.0 milestone Mar 23, 2022
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that explains it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find matches are sometimes incomplete
2 participants