devcontainer: upgrade to node v14.x #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerch
reviewed
May 17, 2021
There was a problem hiding this comment.
@silamon
Thx for finding this one. I cannot approve this one on my own, as I dont use the Docker build for anything. Do those manual lib installs in the Dockerfile still work? Not sure if the image changed the distro base, can you confirm, that yarn test and yarn test-api still works (not even sure how to test that)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the devcontainer setup from node v10 to node v14. Since some devdependencies require at least node v12, it was no longer possible to run
yarnsuccessfully with node v10.