Fix #2714 - Start demo server before running integration tests #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use port 3001 instead of 300 to not conflict with the demo
Tyriar
requested changes
Apr 6, 2021
There was a problem hiding this comment.
This is great!
We can also remove the hacky server starts in the linux and mac integration tests jobs, reducing CI time by ~10 seconds:
Lines 103 to 106 in 26cda84
|
Okay, that makes sense, should the integration tests start running on windows as well, then?
|
|
It would be good to run windows too, I forgot why they were disabled though. Can try enable in a separate pr and see what happens? |
|
This is ready to review. Also I opened #3299 the tests ssem to be running okay on windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2714