-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hover and leave callbacks for linkprovider #3233
Merged
Tyriar
merged 3 commits into
xtermjs:master
from
marvinthepa:3056_hover_callback_link_providers
Feb 3, 2021
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
* @license MIT | ||
*/ | ||
|
||
import { Terminal, ILinkMatcherOptions, ITerminalAddon, IDisposable } from 'xterm'; | ||
import { Terminal, ILinkMatcherOptions, ITerminalAddon, IDisposable, IViewportRange } from 'xterm'; | ||
import { WebLinkProvider } from './WebLinkProvider'; | ||
|
||
const protocolClause = '(https?:\\/\\/)'; | ||
|
@@ -36,27 +36,34 @@ function handleLink(event: MouseEvent, uri: string): void { | |
} | ||
} | ||
|
||
interface ILinkProviderOptions { | ||
hover?(event: MouseEvent, text: string, location: IViewportRange): void; | ||
leave?(event: MouseEvent, text: string): void; | ||
} | ||
|
||
export class WebLinksAddon implements ITerminalAddon { | ||
private _linkMatcherId: number | undefined; | ||
private _terminal: Terminal | undefined; | ||
private _linkProvider: IDisposable | undefined; | ||
|
||
constructor( | ||
private _handler: (event: MouseEvent, uri: string) => void = handleLink, | ||
private _options: ILinkMatcherOptions = {}, | ||
private _options: ILinkMatcherOptions | ILinkProviderOptions = {}, | ||
private _useLinkProvider: boolean = false | ||
) { | ||
this._options.matchIndex = 1; | ||
} | ||
|
||
public activate(terminal: Terminal): void { | ||
this._terminal = terminal; | ||
|
||
if (this._useLinkProvider && 'registerLinkProvider' in this._terminal) { | ||
this._linkProvider = this._terminal.registerLinkProvider(new WebLinkProvider(this._terminal, strictUrlRegex, this._handler)); | ||
const options = this._options as ILinkProviderOptions; | ||
this._linkProvider = this._terminal.registerLinkProvider(new WebLinkProvider(this._terminal, strictUrlRegex, this._handler, options)); | ||
} else { | ||
// TODO: This should be removed eventually | ||
this._linkMatcherId = (this._terminal as Terminal).registerLinkMatcher(strictUrlRegex, this._handler, this._options); | ||
const options = this._options as ILinkMatcherOptions; | ||
options.matchIndex = 1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I moved this here to avoid setting it when the object gets used for a link provider |
||
this._linkMatcherId = (this._terminal as Terminal).registerLinkMatcher(strictUrlRegex, this._handler, options); | ||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marvinthepa normally using
as
is bad, but it doesn't matter much here since the objects are definitely compatible.