Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webgl renderer does not render when writing if a selection exists #3232

Merged
merged 5 commits into from
Feb 3, 2021

Conversation

jeanp413
Copy link
Contributor

Fixes #3221

Also fixes the following issue:

  1. Make a selection
  2. Resize terminal rows or columns
  3. 🐛 Selected text is rendered incorrectly

I chose to behave as the canvas renderer by removing the selection when resizing
xterm_selection_1

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work nicely 👍

I chose to behave as the canvas renderer by removing the selection when resizing

I think we want to keep this behavior to align with the dom renderer as we will be removing the canvas one eventually. It's useful because resizing the terminal by dragging isn't the only cause for resize, it can also happen when maximizing the terminal panel in VS Code or zooming the window (ctrl++/-); we shouldn't be dropping the selection if it's still valid because the user might still want it.

@jeanp413
Copy link
Contributor Author

jeanp413 commented Feb 3, 2021

Updated the PR to keep the selection on resize and when updating colors

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webgl renderer does not render when writing if a selection exists
2 participants