New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "term.fit is not a function" error when change padding value in the demo #3136

Merged

Tyriar merged 1 commit into xtermjs:master from kena0ki:termfit

Oct 30, 2020

Contributor

kena0ki commented Oct 21, 2020

When we change a padding value in the demo, a console error occurs and xterm is not correctly fitted.

I replaced function call from term.fit() to addons.fit.instance.fit().


          Replace function call from term.fit() to addons.fit.instance.fit()

c610768

Tyriar approved these changes

View reviewed changes

Member

Tyriar left a comment

Thanks!

Tyriar added this to the 4.10.0 milestone

Tyriar merged commit 02e4db4 into xtermjs:master

kena0ki deleted the termfit branch

November 15, 2020 06:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet