Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move InputHandler into common #2874

Merged
merged 25 commits into from
Apr 26, 2020
Merged

Move InputHandler into common #2874

merged 25 commits into from
Apr 26, 2020

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Apr 26, 2020 •
edited
Loading

Part of #1507
Part of #2749

Tyriar added 22 commits April 25, 2020 10:21
@Tyriar
Create CoreTerminal, fix createInstance in strict mode
353a8c5
@Tyriar
Remove remaining common service inits to common
0d3bd20
@Tyriar
Move option listeners to core
b80c146
@Tyriar
Move bracketed paste mode to coreservice
4cec11b
@Tyriar
Move insertMode into core service
d5729f9
@Tyriar
Move sendFocus to core service
37996bc
@Tyriar
Remove mouseEvents from Terminal
c5ba1d6 
Depend on CoreMouseService directly
@Tyriar
Remove Terminal.showCursor dep from input handler
9346eba
@Tyriar
Remove Terminal.handleTitle dep
e9db1ec
@Tyriar
Remove a11y event dep, introduce forwardEvent helper
3897950
@Tyriar
Break input handler dep on Terminal.scroll
0709b0d
@Tyriar
Remove unused imports
a3ac0d5
@Tyriar
More some of Terminal.resize into bufferservice
eba372e
@Tyriar
Move resize event into bufferservice
a6949d5
@Tyriar
Register forwardEvent calls
451d9aa
@Tyriar
Remove input handler Terminal.resize dep
3a1a0d6
@Tyriar
Move Terminal.is into InputHandler
dbced5c
@Tyriar
Remove Terminal dependency from InputHandler 🎉
ba40fe4
@Tyriar
Remove RenderService dep in InputHandler
81d289b
@Tyriar
Move InputHandler into common
d756086 
Part of xtermjs#2749
Part of xtermjs#1507
@Tyriar
Remove Terminal dep in InputHandler.test
c931341
@Tyriar
Move InputHandler.test into common, fix strict errors
212061b
@Tyriar Tyriar added this to the 4.6.0 milestone Apr 26, 2020
@Tyriar Tyriar self-assigned this Apr 26, 2020
@Tyriar Tyriar merged commit 2fd4c14 into xtermjs:master Apr 26, 2020
@Tyriar Tyriar deleted the layers2 branch April 26, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Tyriar