Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _terminalClass identifier to cursor blink animation css #2676

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Add _terminalClass identifier to cursor blink animation css #2676

merged 1 commit into from
Feb 2, 2020

Conversation

jeffbaier
Copy link
Contributor

So that multiple DOM rendered instances no longer lose the cursor theme color.

This implements the recommended fix by @rj0n3s in the original issue.

Fixes #2674

@jeffbaier
Add _terminalClass identifier to cursor blink animation css
6240a5d 
so that multiple DOM rendered instances no longer lose the cursor theme color
Fixes xtermjs#2674
@jeffbaier jeffbaier requested a review from Tyriar January 22, 2020 21:12
@Tyriar Tyriar added this to the 4.4.0 milestone Jan 31, 2020
Tyriar
Tyriar approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry about the delay.

@Tyriar Tyriar merged commit 46b95ed into xtermjs:master Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Multiple DOM rendered instances will lose the cursor theme
2 participants
@jeffbaier @Tyriar