Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onBinary event #2566

Merged
merged 4 commits into from
Nov 14, 2019
Merged

onBinary event #2566

merged 4 commits into from
Nov 14, 2019

Conversation

jerch
Copy link
Member

@jerch jerch commented Nov 13, 2019

Implements an onBinary event to be used to send non UTF-8 compatible data to the backend. Currently only used for DEFAULT mouse reports.

The event data is a string, but its important to treat it as a binary string, example with node-pty:

term.onBinary(data => pty.write(Buffer.from(data, 'binary')));

in difference to the normal UTF8 data handling:

term.onData(data => pty.write(data));
// equivalent to
term.onData(data => pty.write(Buffer.from(data, 'utf-8')));

Closes #2545, fixes #1962.

Reminder: Add note to encoding article when done.

@jerch jerch self-assigned this Nov 14, 2019
@jerch jerch added area/mouse-support type/enhancement Features or improvements to existing features labels Nov 14, 2019
src/common/services/CoreMouseService.test.ts Show resolved Hide resolved
test/api/MouseTracking.api.ts Show resolved Hide resolved
src/common/services/CoreMouseService.ts Show resolved Hide resolved
@Tyriar Tyriar added this to the 4.3.0 milestone Nov 14, 2019
@jerch jerch merged commit c99a096 into xtermjs:master Nov 14, 2019
@jerch jerch deleted the binary_event branch November 14, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mouse-support type/enhancement Features or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement onBinary data event X10 mouse protocol is capped at 127
2 participants