Forbid only in mocha

[leomoty]

I saw #2489 and was thinking, how about forbidding .only in Mocha for CI only? Should be way easier to catch if someone mistakenly commits it.

 mocha "**/*.api.js" --headless --forbid-only
C:\Users\leomo\Documents\projects\xterm.js\node_modules\yargs\yargs.js:1163
      else throw err
           ^

Error: `.only` forbidden

[Tyriar]

😮 this is awesome! Had no idea this was a thing.

We should also add it for the yarn test-unit above, it probably needs to be passed through inside bin/test.js for that.

[leomoty]

How do you wanna handle that? It seems that argv.length > 2 is considered as test files, is this feature used anywhere?

[Tyriar]

Yeah @jerch added that, how about using the same flag name and doing the test file check by filtering out flag args: nonFlagArgs = argv.filter(e => e.startsWith('--'))?

[leomoty]

I hope I understood you correctly, I think you meant flagArgs there. This should work, by the way.

[Tyriar]

👌

Thanks for looking into this, will prevent accidentally merging .only again 😅