Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debug logging by printing character codes #2424

Merged
merged 3 commits into from
Sep 12, 2019
Merged

Improve debug logging by printing character codes #2424

merged 3 commits into from
Sep 12, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 12, 2019

Screen Shot 2019-09-12 at 11 06 14 AM

@Tyriar Tyriar added this to the 4.1.0 milestone Sep 12, 2019
@Tyriar Tyriar self-assigned this Sep 12, 2019
@Tyriar
Don't transform incoming data
fc4f345 
This would run for all data
@Tyriar Tyriar requested a review from jerch September 12, 2019 18:24
jerch
jerch requested changes Sep 12, 2019
View reviewed changes
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho this should be lazy evaled, see note.

src/common/services/CoreService.ts Outdated Show resolved Hide resolved
@Tyriar Tyriar merged commit 7da361a into xtermjs:master Sep 12, 2019
@Tyriar Tyriar deleted the logging_data branch September 12, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerch jerch jerch requested changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @jerch