-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write callback support #2422
write callback support #2422
Conversation
@Tyriar Was worried that merging the input types along with the additional callback handling would create a negative perf impact, but thats not the case:
Thats on par with our current separated handling without any callback stuff. Same results in the demo with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, still a todo list to action before merging
@jerch is this ready for review/merge? |
@Tyriar Yepp I think so, well - might need some polishing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice work! 👍
PR for callback support in write methods. Also simplifies the write interface supporting both string and raw UTF8 bytes (Uint8Array) in one method.
With the changes its possible to get notified once a chunk of data was parsed by xterm.js:
Fixes #2408.