Copying terminal output copies all trailing whitespace

[Tyriar]

Copying this:

Pasted result:

[parisk]

Thanks for reporting. Will take a look into how could we avoid that. Most probably it will be a hook on the copy event.

[Tyriar]

What are your thoughts on pulling in an npm dependency so that xterm.js is no longer self contained? Specifically clipboard.js as copying to clipboard seems especially tricky in a browser scenario.

[parisk]

@Tyriar we prefer keeping xterm.js as a self-contained library. It seems that we managed to fix this relatively easy in c02cc84 though, without any external dependencies.

Feel free to try this out! It would help us moving forward with merging of #78.

[Tyriar]

I was doing essentially the same thing only ev.clipboardData.setData('text/plain', copiedText); didn't seem to be working in Chrome (needed more tinkering) and support across other older browsers is limited with this approach.

[parisk]

I tried across multiple browsers and this seemed to work everywhere.

Support across older browsers is not a priority for this library though at the moment, thus let's keep this simple until another issue comes up with this.