We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently we only have the onOptionChange event:
onOptionChange
xterm.js/src/common/services/OptionsService.ts
Line 102 in a22ad76
Which leads to checking the options on the other side, this is especially ugly in the larger files:
xterm.js/src/browser/Terminal.ts
Lines 273 to 317 in a22ad76
This sort of thing would encapsulate this repetitive pattern inside options service:
IOptionsService.onSpecificOptionChange(key: 'x' | 'y' | ..., listener: () => void
The text was updated successfully, but these errors were encountered:
Implement IOptionsService.onSpecificOptionChange
a87b6c3
Part of xtermjs#4190
Tyriar
Successfully merging a pull request may close this issue.
Currently we only have the
onOptionChange
event:xterm.js/src/common/services/OptionsService.ts
Line 102 in a22ad76
Which leads to checking the options on the other side, this is especially ugly in the larger files:
xterm.js/src/browser/Terminal.ts
Lines 273 to 317 in a22ad76
This sort of thing would encapsulate this repetitive pattern inside options service:
The text was updated successfully, but these errors were encountered: