Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A large amount of CPU time is spent in loadColorsForCell #4079

Closed
Tyriar opened this issue Aug 28, 2022 · 0 comments · Fixed by #4080
Closed

A large amount of CPU time is spent in loadColorsForCell #4079

Tyriar opened this issue Aug 28, 2022 · 0 comments · Fixed by #4080
Assignees
@Tyriar
Labels
area/addon/webgl area/performance type/enhancement Features or improvements to existing features
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 28, 2022

Probably related to bg/fg override work, it's still not that long in the grand scheme of things, but it would be good to optimize:

image

This is when scrolling a 142x51 terminal in demo
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/performance area/addon/webgl labels Aug 28, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 28, 2022
@Tyriar
Avoid garbage collection in webgl decoration hot code
5e3f63e 
Part of xtermjs#4079
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 28, 2022
@Tyriar
Remove iterators from IDecorationService
0727741 
They're too low performance for typical use cases

Fixes xtermjs#4079
@Tyriar Tyriar mentioned this issue Aug 28, 2022
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 28, 2022
@Tyriar
Remove more garbage collection issues from cell render loop
23ee719 
Part of xtermjs#4079
@Tyriar Tyriar mentioned this issue Aug 28, 2022
Merged
@Tyriar Tyriar added this to the 5.0.0 milestone Aug 28, 2022
@Tyriar Tyriar self-assigned this Aug 28, 2022
@Tyriar Tyriar mentioned this issue Aug 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/webgl area/performance type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Optimize gc from decoration-related hot code paths Tyriar/xterm.js
1 participant
@Tyriar