Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the powerline symbols scale with devicePixelRatio/font size? #4066

Closed
Tyriar opened this issue Aug 24, 2022 · 1 comment · Fixed by #4070
Closed

Should the powerline symbols scale with devicePixelRatio/font size? #4066

Tyriar opened this issue Aug 24, 2022 · 1 comment · Fixed by #4070
Assignees
@Tyriar
Labels
area/addon/canvas area/addon/webgl type/bug Something is misbehaving
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 24, 2022

With a font size of 50 (dpr=1):

image

The powerline symbols here look a little out of place, we should look at how thick the powerline symbols are based on fontSize*dpr approximate it to that.
@Tyriar
Copy link
Member Author

Tyriar commented Aug 26, 2022

It does scale with dpr currently, scaling to font size as well exacerbates the problem of the angle changing though.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 26, 2022
@Tyriar
Improve glyph padding, especially in large font sizes
774ebe4 
Fixes xtermjs#4066
@Tyriar Tyriar mentioned this issue Aug 26, 2022
Merged
@Tyriar Tyriar self-assigned this Aug 26, 2022
@Tyriar Tyriar added this to the 5.0.0 milestone Aug 26, 2022
@Tyriar Tyriar mentioned this issue Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/canvas area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Improve glyph padding and line width, especially in large font sizes Tyriar/xterm.js
1 participant
@Tyriar