Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wide characters are only half underlined #4063

Closed
Tyriar opened this issue Aug 23, 2022 · 1 comment · Fixed by #4077
Closed

Wide characters are only half underlined #4063

Tyriar opened this issue Aug 23, 2022 · 1 comment · Fixed by #4077
Assignees
@Tyriar
Labels
area/addon/canvas area/addon/webgl type/bug Something is misbehaving
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

VS Code issue: microsoft/vscode#158981

👽 現代

image

Unconfirmed which renderers this affects.
@Tyriar Tyriar mentioned this issue Aug 23, 2022
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Aug 27, 2022

Same applies to strikethrough:

image

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 27, 2022
@Tyriar
Take char width into account when drawing underlines/strokethrough
e76918e 
Fixes xtermjs#4063
@Tyriar Tyriar added this to the 5.0.0 milestone Aug 27, 2022
@Tyriar Tyriar self-assigned this Aug 27, 2022
@Tyriar Tyriar mentioned this issue Aug 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/canvas area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Take char width into account when drawing underlines/strokethrough Tyriar/xterm.js
1 participant
@Tyriar